E.Noorlander/CodePress
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add Git repository permission check to Admin Update page

Browse Source
This commit is contained in:
E.Noorlander
2026-07-29 14:33:35 +02:00
parent 2ea22b392a
commit a795307664
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/templates/pages/update.php
+11
View File
@@ -1,5 +1,16 @@
<h2 class="mb-4"><i class="bi bi-cloud-arrow-down"></i> Systeem Update</h2> <h2 class="mb-4"><i class="bi bi-cloud-arrow-down"></i> Systeem Update</h2>
<?php if (isset($isGitWritable) && $isGitWritable === false): ?>
<div class="alert alert-warning mb-4">
<i class="bi bi-exclamation-triangle-fill me-1"></i>
<strong>Schrijfrechten vereist voor Git:</strong> De PHP-webserver heeft geen schrijfrechten op de <code>.git/objects</code> map op de server.
<br><br>
Voer op de live server eenmalig uit in de terminal (als <code>root</code>):
<pre class="bg-dark text-white p-2 rounded mt-2 mb-0 font-monospace">chown -R www-data:www-data /var/www/CodePress</pre>
<small class="text-muted mt-1 d-block">(Vervang <code>www-data</code> door jouw webserver gebruiker, bijvoorbeeld <code>www</code> of <code>nginx</code>, als dat anders is).</small>
</div>
<?php endif; ?>
<?php if (!empty($updateOutput)): ?> <?php if (!empty($updateOutput)): ?>
<div class="card shadow-sm mb-4"> <div class="card shadow-sm mb-4">
<div class="card-header bg-dark text-white"> <div class="card-header bg-dark text-white">
public/admin.php
+5 -1
View File
@@ -1600,8 +1600,12 @@ function handleUpdate(AdminAuth $auth, array $config): void
$cmsVersion = is_array($verData) ? ($verData['version'] ?? '1.7.1') : '1.7.1'; $cmsVersion = is_array($verData) ? ($verData['version'] ?? '1.7.1') : '1.7.1';
} }
// Get git branch // Get git branch & check git permissions
$gitBranch = 'main'; $gitBranch = 'main';
$root = $config['codepress_root'];
$gitDir = $root . '/.git';
$isGitWritable = is_dir($gitDir) && (is_writable($gitDir) && (!is_dir($gitDir . '/objects') || is_writable($gitDir . '/objects')));
if (function_exists('exec')) { if (function_exists('exec')) {
@exec('git rev-parse --abbrev-ref HEAD 2>&1', $branchOutput); @exec('git rev-parse --abbrev-ref HEAD 2>&1', $branchOutput);
if (!empty($branchOutput[0]) && strpos($branchOutput[0], 'fatal') === false) { if (!empty($branchOutput[0]) && strpos($branchOutput[0], 'fatal') === false) {